Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't use the buggy version of aiohttp on windows #283

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

Psycojoker
Copy link
Collaborator

@Psycojoker Psycojoker commented Oct 3, 2024

See #242

ALEPH-205

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.56%. Comparing base (5a95809) to head (e84980b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #283   +/-   ##
=======================================
  Coverage   38.56%   38.56%           
=======================================
  Files          18       18           
  Lines        1932     1932           
  Branches      335      335           
=======================================
  Hits          745      745           
  Misses       1151     1151           
  Partials       36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the BLUE This PR is simple and straightforward. label Oct 3, 2024
Copy link

github-actions bot commented Oct 3, 2024

This PR qualifies for the 'BLUE' category due to the following reasons:

  • The change involves updating the version of the aiohttp dependency from 3.10.6 to 3.9.*.
  • The updated version falls within the minor version range, indicating that the change is likely to be backward-compatible and pose a low risk.
  • The PR introduces no new files or workflows, and the modification is limited to a single dependency.

Given these factors, the PR is categorized as 'BLUE', which suggests that the review process can be relatively straightforward, focusing on potential compatibility issues or improvements to the existing code.

Referenced code:

-  "aiohttp==3.10.6",
+  "aiohttp==3.9.*",

@Psycojoker Psycojoker merged commit 90d9f9d into master Oct 4, 2024
19 checks passed
@Psycojoker Psycojoker deleted the aiohttp-version-windows-bug branch October 4, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLUE This PR is simple and straightforward.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants